Fixed autocomplete execution bug#115
Open
loft-nathan-rockwood wants to merge 2 commits intoclick-contrib:masterfrom
Open
Fixed autocomplete execution bug#115loft-nathan-rockwood wants to merge 2 commits intoclick-contrib:masterfrom
loft-nathan-rockwood wants to merge 2 commits intoclick-contrib:masterfrom
Conversation
auvipy
requested changes
May 2, 2024
Collaborator
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
can you add some test to verify it?
Merged
Contributor
|
You can add some test cases to verify the intended behaviour. |
There was a problem hiding this comment.
Pull request overview
This PR fixes an autocomplete execution bug in the click-repl completer where multiple options with shell_complete functions would incorrectly execute, resulting in only the last option's values being displayed. The fix ensures that the param_called flag is properly reset after processing each option parameter.
Changes:
- Added reset of
param_calledflag toFalseafter processing each option parameter in_get_completion_for_cmd_argsmethod
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without setting param_called back to False, all options with shell_complete are automatically executed. All options are executed from iterating over a list of current arg to end of arg list. This results in only the last option's values being displayed.